[Bug 746010] oggdemux: doesn't go into pull mode even when queue2 ring-buffer is enabled

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Aug 14 03:11:56 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=746010

--- Comment #15 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
This was reverted a while back:

 commit 0a3b584aa0cffa6310de162f0b70f318913d786f
 Author: Tim-Philipp Müller <tim at centricular.com>
 Date:   Wed May 20 10:22:48 2015 +0100

    Revert "oggdemux: Prevent seeks when _SCHEDULING_FLAG_SEQUENTIAL is set"

    This reverts commit 76647f2710d718e27f207b005956b7dba72c2d19.

    Avoiding pull mode activation is a feature regression, and
    demuxers should always use pull mode where that is possible,
    e.g. if there's an upstream queue2 with a ring buffer or
    a download buffer.

    This patch made reverse playback no longer possible over http.

    If the goal is to minimise seeks, then that can still be done
    by making the demuxer behave differently in pull mode if
    the SEQUENTIAL flag is set. If there are bugs, like the demuxer
    needlessly scanning the entire file on start-up in pull mode,
    then those should be fixed instead.

    https://bugzilla.gnome.org/show_bug.cgi?id=746010

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list