[Bug 747728] vp8enc: multipass-mode=2 is not working

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747728

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #26 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Ok, let's get this in then:

commit abc33c928fc39ab58ec7f8f3784b72b4266242ae
Author: Oleksij Rempel <linux at rempel-privat.de>
Date:   Thu Jul 9 09:51:26 2015 +0200

    vp8enc: provide support for multiple pass cache files

    Some files may provide different caps insight of one stream. Since vp8enc
    support caps reinit, we should support cache reinit too.
    If more then file cache file will be created, the naming will be:
    cache
    cache.1
    cache.2
    ...

    https://bugzilla.gnome.org/show_bug.cgi?id=747728

Question: don't we need to reset the cache_idx to 0 somewhere?

When doing multi-pass encoding, do you create a new encoder element? I think it
needs to be reset to 0 in _stop() or so, so that if the same pipeline/element
is re-used for the second pass, it starts reading the right cache files. If you
confirm I'll fix it up.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.