[Bug 753622] New: splitmuxsink: do not destroy the multiqueue & muxer when going to NULL

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753622

            Bug ID: 753622
           Summary: splitmuxsink: do not destroy the multiqueue & muxer
                    when going to NULL
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-good
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: george.kiagiadakis at collabora.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 309257
  --> https://bugzilla.gnome.org/attachment.cgi?id=309257&action=edit
splitmuxsink: do not destroy the multiqueue & muxer when going to NULL

The release_pad() vfunc in splitmuxsink requires the multiqueue and muxer to be
there, otherwise it returns. At the same time, when transitioning from READY to
NULL, those elements are destroyed, so when an external user of the element
tries to release a previously acquired pad *after* the state has changed to
NULL (a totally reasonable thing to do), the pad is not really released and
some resources are leaked.

The attached patch avoids releasing the elements in READY->NULL and only
releases them in NULL->READY in case they were previously created. The elements
are not referenced by splitmuxsink code, they are only referenced by GstBin, so
they are also removed in dispose() by GstBin.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.