[Bug 750101] rtspsrc: send the user-agent header

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Fri Aug 14 05:17:06 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=750101

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #307419|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 307419:
 --> (https://bugzilla.gnome.org/review?bug=750101&attachment=307419)

Looks good except:

::: gst/rtsp/gstrtspsrc.c
@@ +4655,3 @@
+  /* set user-agent */
+  gst_rtsp_message_add_header (&request, GST_RTSP_HDR_USER_AGENT,
+      src->user_agent);

This probably complains if src->user_agent == NULL

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list