[Bug 753701] discoverer: Few trivial fixes in handling error cases

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Mon Aug 17 05:05:48 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=753701

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #309386|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 309386:
 --> (https://bugzilla.gnome.org/review?bug=753701&attachment=309386)

::: tools/gst-discoverer.c
@@ +492,3 @@
     info = gst_discoverer_discover_uri (dc, uri, &err);
+    if (info) {
+      print_info (info, err);

This doesn't seem like the correct fix. If there was an error, you might not
get a info but err might contain useful information. print_info() should
probably just print the error if info==NULL

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list