[Bug 753021] dashdemux: add a check for seek type in parse_seek function

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753021

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308402|none                        |needs-work
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 308402:
 --> (https://bugzilla.gnome.org/review?bug=753021&attachment=308402)

::: ext/dash/gstdashdemux.c
@@ +1132,3 @@

+  /* check if start-type/stop-type is SET */
+  if (start_type == GST_SEEK_TYPE_NONE || stop_type == GST_SEEK_TYPE_NONE) {

Most seeks have stop_type==NONE. You're breaking many things here :)

What are you trying to solve here? It should work fine for NONE seek types
already, just GST_SEEK_TYPE_END might not work (has to be checked)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.