[Bug 753817] subparse: SIGSEGV with abnormal file

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=753817

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #309570|none                        |needs-work
             status|                            |

--- Comment #2 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 309570:
 --> (https://bugzilla.gnome.org/review?bug=753817&attachment=309570)

Good to go almost, can you update the patch? Thanks :)

::: gst/subparse/gstsubparse.c
@@ +487,3 @@
         encoding, err->message);
     g_error_free (err);
+    err = NULL;

Use g_clear_error (&err) here instead. It calls free and sets the pointer to
NULL for safety

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.