[Bug 754076] New: videoconvert: overlay negotiation fails

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754076

            Bug ID: 754076
           Summary: videoconvert: overlay negotiation fails
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: rawoul at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 309955
  --> https://bugzilla.gnome.org/attachment.cgi?id=309955&action=edit
videoconvert: properly transform caps containing added features

With the following pipeline overlay negotiation fails between textoverlay and
the sink:

gst-launch-1.0 videotestsrc ! video/x-raw,format=YUV9 ! textoverlay text=YEAH
font-desc="Arial 60" ! videoconvert ! glimagesink

The caps filter forces videoconvert in non-passthrough mode. The transform_meta
and filter_meta callbacks in videoconvert do let the overlay composition meta
pass, but the caps transformation function (that remove the video format info)
does not account for it. This means the caps with SystemMemory and other caps
features will be ignored.

The attached patch fixes this issue.

Note that there are probably other elements with the same issue. videoscale for
example, but in this case it's more complicated because we also need to scale
the overlay composition.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.