[Bug 754178] gst-discoverer doesn't detect both audio and video of RTSP streams

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=754178

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #310151|none                        |reviewed
             status|                            |

--- Comment #3 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 310151:
 --> (https://bugzilla.gnome.org/review?bug=754178&attachment=310151)

I think the merging should better take place inside uridecodebin

::: gst-libs/gst/pbutils/gstdiscoverer.c
@@ +1233,3 @@

+    if (dc->priv->current_topology) {
+      if (g_list_length (dc->priv->current_topology) > 1) {

> 1? Not > 0? You need to merge once there already is one topology and a new one arrives, no?

@@ +1238,3 @@
+            g_object_new (GST_TYPE_DISCOVERER_CONTAINER_INFO, NULL);
+
+        dc->priv->current_info->stream_info = (GstDiscovererStreamInfo *)
cont;

Now if another topology arrives afterwards, you would add this container here
and the new topology into yet another container. I think it would be better to
merge them into the same container instead.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.