[Bug 738570] flvdemux: add support for accurate seeking

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738570
  GStreamer | gst-plugins-good | git

Tim-Philipp Müller <t.i.m> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
                 CC|                            |t.i.m at zen.co.uk
            Version|1.4.3                       |git
            Summary|flvdemux: Cannot seek       |flvdemux: add support for
                   |accurately                  |accurate seeking
     Ever Confirmed|0                           |1
           Severity|normal                      |enhancement

--- Comment #7 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2015-01-01 16:40:51 UTC ---
Thanks for working on this.

The first patch looks mostly fine to me.

The second patch looks a bit weird to me. Not wrong necessarily, it's just that
we should really never generate a segment event start position just by 'locking
on' the first timestamp, we should always generate a seek event based on the
seek request, possibly adjusted as per the keyframe position, but not anything
else. I suspect what this code (ca. line 1146 in parse_audio_tag and later for
video) is supposed to do is to care for a non-0 based timeline. Perhaps this
needs to be done differently, or the seek handlers should just generate the new
segment event unconditionally in all cases.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.