[Bug 742619] New: videodecoder: Should not renegotiate on finish_frame()

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=742619
  GStreamer | gst-plugins-base | git

           Summary: videodecoder: Should not renegotiate on finish_frame()
    Classification: Platform
           Product: GStreamer
           Version: git
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: nicolas.dufresne at collabora.co.uk
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


It has always been this way, there is obvious way to workaround it, but it make
very little sense to reconfigure on finish frame. On finish frame, it is too
late to negotiate the allocation. In fact, this case only get triggered when we
are already configured and may cause more arm then good.

In most cases, the frame holds a buffer allocated from the previously
negotiated pool. The old pool cannot be stopped or reconfigured, since it has
outstanding buffers.

I think we should drop this check. If there is a video decoder not using one
of:

gst_video_decoder_allocate_output_buffer()
gst_video_decoder_allocate_output_frame()
gst_video_decoder_negotiate ()

It should most likely call gst_video_decoder_negotiate() (if it can
renegotiate). Any known decoder triggers this case ? If so, do it work well ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.