[Bug 739992] h264parse: expose compatible profiles to downstream

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=739992
  GStreamer | gst-plugins-bad | git

Víctor Manuel Jáquez Leal <vjaquez> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |vjaquez at igalia.com

--- Comment #39 from Víctor Manuel Jáquez Leal <vjaquez at igalia.com> 2015-01-09 00:17:26 UTC ---
(In reply to comment #38)
> I didn't change anything in get_caps implementation with this patch and I can't
> reproduce this issue with the command mentioned in comment #30 too.  Is it
> possible for someone to have a try with this patch once more?

Perhaps I'm missing something, but I have ran this command twice:

$ gst-validate-transcoding-1.0  -o
"video/quicktime,variant=iso;:video/x-h264:audio/mpeg,mpegversion=1,layer=3"
file:///home/vjaquez/gst-validate/gst-integration-testsuites/medias/defaults/mpegts/GH1_00094_1920x1280.MTS
file:///home/vjaquez/gst-validate/rendered/validate/file/to_mp3_and_h264_in_mp4/GH1_00094_1920x1280_MTS
--gst-debug=*:3

One with sreerenj's patch and another with its reversion. In both cases I got
the same error:

==== Got criticals, Return value set to 18 ====
     Critical error Peer pad structure 'audio/x-raw, rate=(int){ 8000, 11025,
12000, 16000, 22050, 24000, 32000, 44100, 48000 }, channels=(int)1,
format=(string)S16LE, layout=(string)interleaved;' has no similar version on
pad's caps 'audio/x-ac3, rate=(int)48000, channels=(int)2,
framed=(boolean)true, alignment=(string)frame'


:00:00.146352550  9763 0x7f2de40368f0 ERROR               validate
gst-validate-reporter.c:207:gst_validate_report_valist: <avdec_ac3-0:sink> 1802
(critical) : caps: getcaps function isn't proxying downstream fields correctly
: Peer pad structure 'audio/x-raw, rate=(int){ 8000, 11025, 12000, 16000,
22050, 24000, 32000, 44100, 48000 }, channels=(int)1, format=(string)S16LE,
layout=(string)interleaved;' has no similar v
ersion on pad's caps 'audio/x-ac3, rate=(int)48000, channels=(int)2,
framed=(boolean)true, alignment=(string)frame'

IMO this regression is not related with the h264parse (yet), but  with ac3parse
/ avdec_ac3.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.