[Bug 599018] caca: Cleanups and fixes

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=599018
  GStreamer | gst-plugins-good | git

--- Comment #14 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2015-01-10 21:10:32 UTC ---
Review of attachment 278676:
 --> (https://bugzilla.gnome.org/review?bug=599018&attachment=278676)

::: ext/libcaca/gstcacasink.c
@@ +190,3 @@
+  g_object_class_install_property (G_OBJECT_CLASS (klass), PROP_DRIVER,
+      g_param_spec_enum ("driver", "driver", "Output driver",
+          GST_TYPE_CACADRIVER, 0, G_PARAM_READWRITE));

| G_PARAM_STATIC_STRINGS

@@ +407,3 @@
+  cacasink->dp =
+      caca_create_display_with_driver (cacasink->cv,
+      driver_array[cacasink->driver]);

You can avoid the driver_array.
GEnumValue *ev = g_enum_get_value (enum_class, cacasink->driver);
caca_create_display_with_driver (cacasink->cv, ev->value_nick)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.