[Bug 742757] New: vtenc_h264 ignores 'quality' setting

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=742757
  GStreamer | gst-plugins-bad | 1.4.5

           Summary: vtenc_h264 ignores 'quality' setting
    Classification: Platform
           Product: GStreamer
           Version: 1.4.5
        OS/Version: Mac OS
            Status: UNCONFIRMED
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: denis.shmyrov at gmail.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


I’ve found an issue in the vtenc.c when the ‘quality’ setting doesn’t get set
for the VTCompressionSession object because self->session is not yet set within
the gst_vtenc_create_session(). The fix is to replace

gst_vtenc_set_quality (self, self->quality);

with

gst_vtenc_session_configure_property_double (self, session,
kVTCompressionPropertyKey_Quality, self->quality);

which will also remove redundant lock on self if gst_vtenc_set_quality is
called. Diff file attached.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.