[Bug 743195] uri: Add parsing unit test based on GNet

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=743195
  GStreamer | gstreamer (core) | unspecified

--- Comment #6 from David Waring <david.waring at rd.bbc.co.uk> 2015-01-20 13:55:20 UTC ---
Review of attachment 294908:
 --> (https://bugzilla.gnome.org/review?bug=743195&attachment=294908)

I found some discrepancies between the tested URI's and their expected output.

::: tests/check/gst/gsturi.c
@@ -167,0 +167,103 @@
+/* Taken from the GNet unit test and extended with other URIs:
+ * https://git.gnome.org/browse/archive/gnet/plain/tests/check/gnet/gneturi.c
+ */
... 100 more ...

The previous 4 test cases all have a scheme but are looking for a NULL scheme
entry in the output

@@ -167,0 +167,126 @@
+/* Taken from the GNet unit test and extended with other URIs:
+ * https://git.gnome.org/browse/archive/gnet/plain/tests/check/gnet/gneturi.c
+ */
... 123 more ...

Paths after an authority must start with a single "/" according to RFC3986. So
in this case the hostname is "hostname" with no port and a path of ":123path".

@@ -167,0 +167,139 @@
+/* Taken from the GNet unit test and extended with other URIs:
+ * https://git.gnome.org/browse/archive/gnet/plain/tests/check/gnet/gneturi.c
+ */
... 136 more ...

Wouldn't the port be 23?

@@ -167,0 +167,144 @@
+/* Taken from the GNet unit test and extended with other URIs:
+ * https://git.gnome.org/browse/archive/gnet/plain/tests/check/gnet/gneturi.c
+ */
... 141 more ...

This should probably cause a parsing error since [ is not allowed without a ]
and [ is not allowed in the other host part forms in RFC3986.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.