[Bug 740196] [PATCH] baseparse: Add vfunc to adjust output segment

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=740196
  GStreamer | gstreamer (core) | git master

Sebastian Dröge (slomo) <slomo> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #290777|none                        |reviewed
             status|                            |

--- Comment #1 from Sebastian Dröge (slomo) <slomo at coaxion.net> 2015-01-20 17:24:08 UTC ---
Review of attachment 290777:
 --> (https://bugzilla.gnome.org/review?bug=740196&attachment=290777)

How would the subclass distinguish the "complete" segment, or a smaller segment
caused by a seek (i.e. bigger start position, smaller stop position, or both).
I think you would need that for the LAME tags as you only want to modify the
very beginning and end, not some segment that is in the middle of the stream.

::: libs/gst/base/gstbaseparse.c
@@ +1245,3 @@
       ret = gst_pad_push_event (parse->srcpad, event);
     } else {
       // GST_VIDEO_DECODER_STREAM_LOCK (decoder);

Not your fault... but!

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.