[Bug 743332] New: aacparse adts header check issue

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=743332
  GStreamer | gst-plugins-good | 1.4.1

           Summary: aacparse adts header check issue
    Classification: Platform
           Product: GStreamer
           Version: 1.4.1
        OS/Version: Linux
            Status: UNCONFIRMED
          Severity: trivial
          Priority: Normal
         Component: gst-plugins-good
        AssignedTo: gstreamer-bugs at lists.freedesktop.org
        ReportedBy: lyon.wang at freescale.com
         QAContact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---


I've met some aac clips play issue which played well on gst0.10. (I will attach
one sample clip)
And I checked the aacparse plugin and found that in gstaacparse.c
gst_aac_parse_detect_stream() it add checkiing channel and frameisze
validation:

if (! channels || framesize) {
      GST_DEBUG_OBJECT (aacparse, "impossible ADTS configuration");
    g_print("++ gstaacpase.c Line:%d, channels = %d, return false ++\n",
__LINE__, channels);
      return FALSE;
    }

The checking doesn't exist in gst0.10 aacparse.
I just wondering if the channels need to be checked or is it a critical error
which return the GST_ERROR and make the clip fail to play.
Because the channel config area read from adts header may not exactly reflect
the audio data channel number, and it is not a necessary input for AAC decoder
(the actual audio channel number should be the output of the aac audio decoder
by counting the single_channnel_element or pair_channel_element in the audio
stream)

Would you give us some advice about this? Thanks.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.