[Bug 738319] rtpsession: fix Early Feedback Transmission

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=738319
  GStreamer | gst-plugins-good | 1.4.1

Olivier Crête <olivier.crete> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #295151|none                        |rejected
             status|                            |

--- Comment #14 from Olivier Crête <olivier.crete at ocrete.ca> 2015-01-22 15:00:47 UTC ---
Review of attachment 295151:
 --> (https://bugzilla.gnome.org/review?bug=738319&attachment=295151)

::: gst/rtpmanager/rtpsession.c
@@ -318,3 +318,3 @@
       G_SIGNAL_RUN_LAST | G_SIGNAL_ACTION,
       G_STRUCT_OFFSET (RTPSessionClass, send_rtcp), NULL, NULL,
-      g_cclosure_marshal_generic, G_TYPE_NONE, 1, G_TYPE_UINT64);
+      g_cclosure_marshal_generic, G_TYPE_BOOLEAN, 1, G_TYPE_UINT64);

I'm pretty sure this is an ABI break. As the g_signal_emit_by_name() function
takes an extra argument if you have a return value. I assume that if you use it
without the extra argument, it may clobber whatever is on the stack at that
point.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.