[Bug 599018] caca: Cleanups and fixes

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=599018
  GStreamer | gst-plugins-good | git master

Stefan Sauer (gstreamer, gtkdoc dev) <ensonic> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #294365|none                        |accepted-commit_now
             status|                            |

--- Comment #17 from Stefan Sauer (gstreamer, gtkdoc dev) <ensonic at sonicpulse.de> 2015-01-23 13:10:17 UTC ---
Review of attachment 294365:
 --> (https://bugzilla.gnome.org/review?bug=599018&attachment=294365)

Just a small suggestions. Thanks!

::: ext/libcaca/gstcacasink.c
@@ +404,3 @@
     goto init_failed;

+  enum_class = g_type_class_ref (GST_TYPE_CACADRIVER);

its probably better to use g_type_class_peek() here, the type is definitely
loaded (as it is an enum on the class) - this way you don't need to unref

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.