[Bug 742684] audiomixer: Un-even locking in GstAggregator causes the tests to fail

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=742684
  GStreamer | gst-plugins-bad | git master

--- Comment #40 from Tim-Philipp Müller <t.i.m at zen.co.uk> 2015-01-23 15:09:04 UTC ---
(From update of attachment 295224)
>+    PAD_LOCK (pad);
>+    if (pad->buffer == NULL && !pad->eos) {
>+      GST_OBJECT_UNLOCK (pad);
>       goto pad_not_ready;
>+    }
>+    PAD_UNLOCK (pad);

Surely the middle bit should be PAD_UNLOCK as well for consistency? (perhaps
it'd be nicer with a temp variable)

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.