[Bug 727483] v4l2sink: Keep aspect ratio when device scale

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=727483
  GStreamer | gst-plugins-good | unspecified

Nicolas Dufresne (stormer) <nicolas.dufresne> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #285272|none                        |reviewed
             status|                            |

--- Comment #10 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2015-01-25 16:36:54 UTC ---
Review of attachment 285272:
 --> (https://bugzilla.gnome.org/review?bug=727483&attachment=285272)

Just checking, do we keep aspect ratio by default with that path ?

::: sys/v4l2/gstv4l2sink.c
@@ +586,3 @@
   /* TODO: videosink width/height should be scaled according to
    * pixel-aspect-ratio
    */

Can't this comment be removed now ? If not why ?

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.