[Bug 738319] rtpsession: fix Early Feedback Transmission

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Sun Jan 25 20:02:07 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=738319
  GStreamer | gst-plugins-good | 1.4.1

--- Comment #28 from Olivier CrĂȘte <olivier.crete at ocrete.ca> 2015-01-25 21:18:16 UTC ---
Review of attachment 295380:
 --> (https://bugzilla.gnome.org/review?bug=738319&attachment=295380)

::: gst/rtpmanager/rtpsession.c
@@ +3101,3 @@
+  if (gst_rtcp_buffer_get_first_packet (&rtcp, &packet)) {
+    /* FIXME: Do we also need to compare the ssrc in the packet with the
+     * source's ssrc? */

I think so, the packet we're trying to duplicate could also have come from
another peer in the group, and there could be multiple senders.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list