[Bug 742684] aggregator: Locking logic should be reviewed, cleaned up, and documented

GStreamer (bugzilla.gnome.org) bugzilla at gnome.org
Mon Jan 26 14:30:05 PST 2015


https://bugzilla.gnome.org/show_bug.cgi?id=742684
  GStreamer | gst-plugins-bad | git master

--- Comment #62 from Olivier CrĂȘte <olivier.crete at ocrete.ca> 2015-01-26 22:30:02 UTC ---
Should probably squash your patches and mine and remove the _unlocked() variant
that no longer makes sense if it's not the same lock. Also need to document the
locking order between the GstAggregator pad lock and the GstObject lock of the
element and the pad. In the
STREAM_LOCK(sinkpad)->STREAM_LOCK(srcpad)->OBJECT_LOCK(element)->OBJECT_LOCK(pad)
order, I guess it goes between OBJECT_LOCK(element) and OBJECT_LOCK(pad) ?
Which is a bit strange, but oh well.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list