[Bug 741030] theoradec: Sets video-meta width/height from padded values

[GStreamer (bugzilla.gnome.org)]

https://bugzilla.gnome.org/show_bug.cgi?id=741030
  GStreamer | gst-plugins-good | git master

--- Comment #7 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> 2015-01-31 18:10:17 UTC ---
(In reply to comment #6)
> It's a bit late to redefine which width/heights we pass around in GstVideoMeta
> and GstVideoCropMeta, isn't it?

I don't think it has ever been defined before. This assert in GstVideoFrame is
the first time we enforce something. The problem with setting cropped size in
VideoMeta is mostly conceptual. Basically, a crop from theroadec can fall
outside the "map region". This is prone to errors like short allocation, and
also prevent generic API like GstVideo to validate anything.

There would be another benefit on having VideoMeta having padded size, which
would be that video filter could work just fine even if they don't know about
crop meta. They would apply the effect on the entire surface. This would be a
bit too much work, but would be fine for uniform effects like color transform
(for overlays, not so much though).

Note that I still think for this decoder, we should use the video alignment
like libav do. The nature of padding is exactly the same.

-- 
Configure bugmail: https://bugzilla.gnome.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.