[Bug 751883] New: rtcpbuffer: Fix validation of packets with padding

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751883

            Bug ID: 751883
           Summary: rtcpbuffer: Fix validation of packets with padding
    Classification: Platform
           Product: GStreamer
           Version: 1.5.2
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-base
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: stian.selnes at gmail.com
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

Created attachment 306687
  --> https://bugzilla.gnome.org/attachment.cgi?id=306687&action=edit
Patch with fix and tests

Attached patch fixes the validation of rtcp buffers with padding. It also adds
a few tests for both compound and reduzed size rtcp packets. The padding (if
any) is included in the length of the last packet.

Extracts from RFC 3550:

Section 6.4.1:
   padding (P): 1 bit
      If the padding bit is set, this individual RTCP packet contains
      some additional padding octets at the end which are not part of
      the control information but are included in the length field.

Section A.2:
   *  The padding bit (P) should be zero for the first packet of a
      compound RTCP packet because padding should only be applied, if it
      is needed, to the last packet.

   *  The length fields of the individual RTCP packets must add up to
      the overall length of the compound RTCP packet as received.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.