[Bug 751735] dashdemux: incorrect parsing and handling of segment templates

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751735

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |thiagossantos at gmail.com

--- Comment #2 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
(In reply to Florin Apostol from comment #0)
> {"Number", "Number"},       /* string similar with an identifier, but
> without $ */
> {"Number$Number$", "Number7"},      /* Number identifier */
> {"Number$Number$$$", "Number7$"},   /* Number identifier followed by $$ */

> {"Number$Number$Number$Number$", "Number7Number7"}, /* series of "Number"
> string and Number identifier */

I'm not sure about this one, I think your interpretation is correct because the
spec tells to replace the $Number$ with the value and then the 2nd $Number$
would lose its first $ and would not be replaced, but what if we start
replacing from the end towards the start or if all replacements should be done
'at the same time'? What interpretation could have us covering most of the
valid use cases?

> {"TestMedia$Time", NULL},   /* Identifier not finished with $ */
> {"Time$Time%0d$", "Time100"},       /* usage of format smaller than number
> of digits */
> {"Time$Time%01d$", "Time100"},      /* usage of format smaller than number
> of digits */
> {"Time$Time%05d$", "Time00100"},    /* usage of format bigger than number of
> digits */

> {"Time$Time%05dtest$", "Time00100test"},    /* usage extra text in format */

Is this valid? I couldn't find anything in the spec that allowed suffixing that
was not the %0d identifier.

> {"Time$Time1%01d$", NULL},  /* incorrect format: does not start with % after
> identifier */
> {"$RepresentationID1$", NULL},      /* incorrect identifier */
> {"$Bandwidth1$", NULL},     /* incorrect identifier */
> {"$Number1$", NULL},        /* incorrect identifier */
> {"$RepresentationID%01d$", NULL},   /* incorrect format: RepresentationID
> does not support formatting */

> {"Time$Time%05u$", "Time00100"},    /* %u format */
> {"Time$Time%05x$", "Time00064"},    /* %x format */
> {"Time$Time%05utest$", "Time00100test"},    /* %u format followed by text */
> {"Time$Time%05xtest$", "Time00064test"},    /* %x format followed by text */
Are %u and %x allowed by the spec? It seems that it should always be a %d but
as it is a bit dubious I'd be ok for accepting those as well.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.