[Bug 752041] ximagesink: fix navigation event leak

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752041

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #306965|none                        |reviewed
             status|                            |

--- Comment #4 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 306965:
 --> (https://bugzilla.gnome.org/review?bug=752041&attachment=306965)

::: sys/ximage/ximagesink.c
@@ +1565,3 @@
+    event = gst_event_new_navigation (structure);
+    if (GST_IS_EVENT (event))
+      gst_pad_send_event (pad, event);

Why check if it's a valid event? It must be :)

Also why is this not just using gst_pad_push_event() on the sinkpad of
xvimagesink, then it wouldn't matter if there was a peer or not.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.