[Bug 751778] metainfo: some meta has no transform_func in plugins

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751778

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #306970|none                        |needs-work
             status|                            |

--- Comment #16 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 306970:
 --> (https://bugzilla.gnome.org/review?bug=751778&attachment=306970)

::: gst-libs/gst/codecparsers/gstmpegvideometa.c
@@ +90,3 @@
+  }
+
+  return TRUE;

No, this should return FALSE in both cases here:
- if gst_buffer_add_mpeg_video_meta() fails
- if the transform type is not handled


All cases other than the one where adding the meta succeeded should return
FALSE. Same goes for all the other patches

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.