[Bug 751540] gltestsrc: implement missing patterns, port to GL3 / ES3, load shaders with GIO

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751540

Matthew Waters <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #306164|none                        |needs-work
             status|                            |

--- Comment #10 from Matthew Waters <ystreet00 at gmail.com> ---
Review of attachment 306164:
 --> (https://bugzilla.gnome.org/review?bug=751540&attachment=306164)

The shader should be ported to GLES2 instead.

::: ext/gl/gltestsrc.c
@@ +240,3 @@
     attr_uv_loc = gst_gl_shader_get_attribute_location (v->shader, "uv");

+    glGenVertexArrays (1, &vertex_array);

Generating VAO's every frame is not a good idea.

@@ +249,3 @@
+    glEnableVertexAttribArray (attr_position_loc);
+    glBufferData (GL_ARRAY_BUFFER, 16 * sizeof (GLfloat), positions,
+        GL_STATIC_DRAW);

Uploading unchanging data every frame is a bad idea :)

@@ +256,3 @@
+    glVertexAttribPointer (attr_uv_loc, 2, GL_FLOAT, GL_FALSE, 0, 0);
+    glEnableVertexAttribArray (attr_uv_loc);
+    glBufferData (GL_ARRAY_BUFFER, 8 * sizeof (GLfloat), uvs, GL_STATIC_DRAW);

Uploading unchanging data every frame is a bad idea :)

@@ +262,3 @@
+    glBindBuffer (GL_ELEMENT_ARRAY_BUFFER, index_buffer);
+    glBufferData (GL_ELEMENT_ARRAY_BUFFER, 5 * sizeof (GLuint), indices,
+        GL_STATIC_DRAW);

Uploading unchanging data every frame is a bad idea :)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.