[Bug 751540] gltestsrc: implement missing patterns, port to GL3 / ES3, load shaders with GIO

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=751540

Matthew Waters <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #306167|none                        |needs-work
             status|                            |

--- Comment #13 from Matthew Waters <ystreet00 at gmail.com> ---
Review of attachment 306167:
 --> (https://bugzilla.gnome.org/review?bug=751540&attachment=306167)

Port the shaders to GLES2.

::: configure.ac
@@ +301,3 @@
+dnl gio-2.0 is optional and used in gltransformation
+HAVE_GIO=NO
+PKG_CHECK_MODULES(GIO, gio-1.0 >= 1.0.0, HAVE_GIO=yes, HAVE_GIO=no)

gio-1.0 doesn't exist (gio-2.0 does).  Also need to find the version that
started having GResource.

::: ext/gl/Makefile.am
@@ +148,3 @@
     $(LIBM) \
+    $(GRAPHENE_LIBS) \
+  $(GIO_LIBS)

Incorrect tab usage for a makefile

::: ext/gl/gltestsrc.c
@@ +240,3 @@
+  const char *color_fragment = gst_gl_test_src_read_shader ("color.frag");
+  const char *snow_vertex = gst_gl_test_src_read_shader ("snow.vert");
+  const char *snow_fragment = gst_gl_test_src_read_shader ("snow.frag");

Shouldn't leak the shaders.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.