[Bug 752027] dashdemux: tests: improve unit test code coverage

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752027

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #307019|reviewed                    |needs-work
             status|                            |

--- Comment #9 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Comment on attachment 307019
  --> https://bugzilla.gnome.org/attachment.cgi?id=307019
replaced patch 5/5

This fails now with latest GIT:
98%: Checks: 85, Failures: 1, Errors: 0
elements/dash_mpd.c:3119:F:complexMPD:dash_mpdparser_segments:0:
'hasNextSegment' (0) is not equal to '1' (1)
Makefile:3867: recipe for target 'elements/dash_mpd.check' failed


The test in question checks if with segment_index=0 and segments_count=1, there
has_next_segment() returns TRUE. It assumes it should, but it doesn't. Which is
AFAIU correct: if you have segment_index=0 and segments_count=1, then there is
no next segment. Segment indices start at 0 and go up to segment_count-1.

Without the change that broke your test, we won't be able to detect if we
expect a next segment or not.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.