[Bug 752092] avidemux: audio skips on some files after update from 1.4 to 1.5

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752092

Sebastian Dröge (slomo) <slomo at coaxion.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #307050|none                        |needs-work
             status|                            |

--- Comment #5 from Sebastian Dröge (slomo) <slomo at coaxion.net> ---
Review of attachment 307050:
 --> (https://bugzilla.gnome.org/review?bug=752092&attachment=307050)

::: libs/gst/base/gstadapter.c
@@ +936,3 @@
+    data = g_malloc (hsize);
+    gst_buffer_extract (cur, skip, data, hsize);
+    buffer = gst_buffer_new_wrapped (data, hsize);

The difference here is that your version is a new buffer, the old code is the
old buffer with the old metadata (timestamp, duration, GstMeta).

To me this looks like avidemux or whatever does not consider the GstAdapter
documentation: the buffers returned can have arbitrary metadata set on them,
and it's the caller's job to make sure that it is correct.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.