[Bug 752092] baseparse: Passes bogus buffer durations to subclass

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752092

--- Comment #14 from Vineeth <vineeth.tm at samsung.com> ---
This change is ok..


But my concern is, when we get buffer from adapter,
dont we need to get proper duration for all conditions? or rather all other
buffer values?
base parse does not need proper duration. So it is fine i guess..

But
  data = gst_adapter_get_internal (adapter, nbytes);

  buffer = gst_buffer_new_wrapped (data, nbytes);
is not copying all the buffer values i guess right?

i mean how else was the duration was coming as some finite value, when we just
ref the buffer and return
and for other conditions, we are creating a new buffer and all the values are
not copied i guess. Duration was coming as GST_CLOCK_TIME_NONE. So guessing
none of the other values are being copied to the new buffer?

Should we copy all the values to the new buffer similar to how we are copying
metadata?

Not sure if i am making sense :D

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.