[Bug 752367] New: dashdemux: adaptation set language could be better detected

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752367

            Bug ID: 752367
           Summary: dashdemux: adaptation set language could be better
                    detected
    Classification: Platform
           Product: GStreamer
           Version: git master
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: Normal
         Component: gst-plugins-bad
          Assignee: gstreamer-bugs at lists.freedesktop.org
          Reporter: florin.apostol at oregan.net
        QA Contact: gstreamer-bugs at lists.freedesktop.org
     GNOME version: ---

The gst_dash_demux_setup_all_streams function will try to set the language of
the current stream. First it looks at the lang attribute in the AdaptationSet
and if that is not found, it will look at the lang attribute in
ContentComponent, but only if there is a single ContentComponent present. The
standard says that if multiple components are present, their settings are
specified using ContentComponent elements in the AdaptationSet (instead of
embedding the settings directly in the AdaptationSet).

Thus, if more than one component is present, the
gst_dash_demux_setup_all_streams function will fail to set the language.

The code 
      /* Fallback to the language in ContentComponent node */
      if (lang == NULL && g_list_length (adp_set->ContentComponents) == 1) {
        GstContentComponentNode *cc_node = adp_set->ContentComponents->data;
        lang = cc_node->lang;
      }

should be rewritten to search the components list (regardless of size) and pick
the first language found.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.