[Bug 752421] matroskademux: SRT subtitles with markup are displayed with a trailing asterisk

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752421

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
                 CC|                            |t.i.m at zen.co.uk
         Resolution|---                         |FIXED
   Target Milestone|git master                  |1.5.3
            Summary|[PATCH] Matroska SRT        |matroskademux: SRT
                   |subtitles with markup are   |subtitles with markup are
                   |displayed with a trailing   |displayed with a trailing
                   |asterisk                    |asterisk

--- Comment #2 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Thanks, this looks right to me. The buffers we push out should not contain a
trailing NUL character in the (visible) buffer data, it's just added for
safety.

commit 45892ec8becdc6b5d1d72a1b90b42f90b699cf7e
Author: Dimitrios Christidis <dchristidis at mykolab.com>
Date:   Wed Jul 15 13:44:52 2015 +0300

    matroskademux: fix trailing '*' displayed with some text subtitles

    The subtitle buffer we push out should not include a NUL terminator
    as part of the data, we just add such a terminator for safety, but
    it should not be included in the buffer size.

    A NUL terminator is not valid UTF-8, so checks will fail if it's
    included in the size, and the NUL will be replaced by the fallback
    character specified when converting, i.e. '*'.

    https://bugzilla.gnome.org/show_bug.cgi?id=752421

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.