[Bug 739472] multifilesrc: Lost the ability to start at a different frame

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=739472

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #301534|none                        |needs-work
             status|                            |

--- Comment #10 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 301534:
 --> (https://bugzilla.gnome.org/review?bug=739472&attachment=301534)

::: gst/multifile/gstmultifilesrc.c
@@ +302,3 @@
+   * several times, as relevant parameters are set (index, caps...) */
+  gboolean started =
+      GST_PAD_MODE (GST_BASE_SRC (src)->srcpad) == GST_PAD_MODE_PUSH;

You should read this with the object lock held.

@@ +308,3 @@
+
+    pos =
+        gst_util_uint64_scale (src->index, src->fps_d * GST_SECOND,
src->fps_n);

This is not media agnostic. What about picking FORMAT_DEFAULT, and seeking in
files ? Also, you didn't protect for the case framerate=0/1.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.