[Bug 752421] matroskademux: SRT subtitles with markup are displayed with a trailing asterisk

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752421

--- Comment #9 from Dimitrios Christidis <dchristidis at mykolab.com> ---
With the first patch merged, the function will not work correctly on subtitle
buffers with NUL terminators as part of the data. I do not have a test case for
this, but according to bug #707933 it could happen. Thus, that bug would be
reopened.

I think the third patch is the better approach. Per our discussion on IRC, when
shrinking a buffer, one should not rely on the trimmed data being there.
Furthermore, no part of the codebase that handles subtitle buffers should
depend on the existence of a NUL terminator. Finally, I think it looks cleaner,
but this is subjective.

The commit message certainly needs some work from a developer with more
experience.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.