[Bug 745107] glimagesink: implement GstVideoOverlayCompositionMeta

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745107

Matthew Waters <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|RESOLVED                    |REOPENED
         Resolution|FIXED                       |---
           Severity|enhancement                 |blocker

--- Comment #67 from Matthew Waters <ystreet00 at gmail.com> ---
This was not ready to be merged for the following reasons.

1. gst-launch-1.0 videotestsrc ! textoverlay text=YAY ! glimagesink and resize
the window.  The text does not stay in the same place relative to the video.
2. The inconsistent gloverlaycompositor/glcompositionoverlay naming
3. Point 2 should have really been a single file containing both objects, the
overall compositor and the GstVideoOverlayComposition wrapper object.  Ideally
the wrapper object should be entirely internal to the compositor.
4. Reliance on a passed in shader/attributes that we have no idea of the
contents of.  The compositor should create it's own shader.
5. gst_video_meta_map instead of gst_video_frame_map usage?
6. Not ensuring that the data pointer passed to gst_gl_memory_wrapped is always
valid as long the memory is (it may have disappeared at the time of _unmap()).
7. Stride paramater not passed between video_meta_map() and the wrapped
GstVideoInfo.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.