[Bug 745107] glimagesink: implement GstVideoOverlayCompositionMeta

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=745107

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #88 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
This fixes concern 5, 6 and 7. And fixes a regression in Lubosz branch when he
added meta parameter.

About the 3D stuff, gstglviewconvert, which I believe is needed, does not
forward the composition meta, which should lead to textoverlay not attaching
it. That's what I expected, please confirm me if I'm wrong. So the bad result
is because textoverlay does not support (and does not fail) in presence of 3D
view. Sink support for that seems like the step after fixing the software
renderer.

About the window pixel-aspect-ratio. It would be a nice to have, but not
passing it does not result in bug of any kind. The only side, is that the
overlay is being scaled, which arguable is something we try to avoid to produce
perfect quality subtitle. I'll file a separate bug for that one.

commit 4f4aedecf37830e95676cfbb407540e654de9527
Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Date:   Wed Jul 22 16:58:12 2015 -0400

    glupload: Forward composition meta even without params

    When the sink does not know the window size (e.g not created yet)
    it will not add any param to the the composition meta. This is no
    reason not to forward this meta API. Fixes issue where it could not
    attach until we resize the window.

    https://bugzilla.gnome.org/show_bug.cgi?id=745107

commit e310e6d5403d703c241fb1fa84977113cb828651
Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Date:   Wed Jul 22 15:56:34 2015 -0400

    gloverlaycompositor: Keep memory pointer alive

    Keep the composition memory pointer alive while it's being
    wrapped inside a GstGLMemory object.

    https://bugzilla.gnome.org/show_bug.cgi?id=745107

commit 9c020443e6959b7c710e6de2ddbee36e9e2a3aab
Author: Nicolas Dufresne <nicolas.dufresne at collabora.com>
Date:   Wed Jul 22 14:17:42 2015 -0400

    gloverlaycompositor: Pass buffer stride

    The overlay pixel buffer stride was not given back
    to the GL image.

    https://bugzilla.gnome.org/show_bug.cgi?id=745107

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.