[Bug 752613] qtdemux: unsigned raw 16 bit PCM audio not working

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752613

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #307731|none                        |needs-work
             status|                            |

--- Comment #11 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 307731
  --> https://bugzilla.gnome.org/attachment.cgi?id=307731
The above is the diff patch code.

Thanks for the patch and the sample files.

I can confirm the patch works.

Please could you update the patch as follows:

 - provide a patch in 'git format-patch' format with author and commit message
set and bugzilla url to this ticket in the commit message

 - there seem to be spaces and/or tabs at the end of some lines (they show up
in red when you do 'git diff' for uncommitted changes or 'git show' for the
last commit). Please remove those.

 - please ensure correct indentation (spaces only, no tabs please). The easiest
way is to run gst-indent on the code (but see next item)

 - I think in the NONE/raw case, we should just check for
stream->bytes_per_packet == 1 and use the current code, and otherwise just fall
through to the 'twos' case, which does what we want already.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.