[Bug 752743] gl: add support for egl+x11+swrast on osx

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752743

Matthew Waters <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308044|none                        |needs-work
             status|                            |

--- Comment #13 from Matthew Waters <ystreet00 at gmail.com> ---
Review of attachment 308044:
 --> (https://bugzilla.gnome.org/review?bug=752743&attachment=308044)

::: configure.ac
@@ +831,3 @@
+  case "$host" in
+    *-*darwin*)
+      GL_CFLAGS="-Wno-typedef-redefinition"

Again, not a fan of disabling the typedef redefinition on osx.  Should also
hide behind the $HAVE_EGL/$NEED_EGL check like the hunk below.

::: gst-libs/gst/gl/gstglcontext.c
@@ +124,3 @@
+#ifdef __APPLE__
+  if (!module_opengl && (_get_default_gl_platform () == GST_GL_PLATFORM_EGL))
+    module_opengl = g_module_open ("libGL.dylib", G_MODULE_BIND_LAZY);

You should probably remove the && _get_default_gl_platform() == to always get
the dylib on OS X.  The g_module_open call below is targetted to loadable
modules which OS X differentiates between that and shared libraries.  See
http://www.finkproject.org/doc/porting/porting.en.html#shared.lib-and-mod

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.