[Bug 752613] qtdemux: unsigned raw 16 bit PCM audio not working

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752613

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308071|none                        |needs-work
             status|                            |

--- Comment #22 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
Comment on attachment 308071
  --> https://bugzilla.gnome.org/attachment.cgi?id=308071
The diff patch after refactoring.

Thanks for your patience :)

I think this new patch still has an issue: it makes NONE/raw 8-bit audio S8
instead of U8, if I'm not mistaken.

I think to fix this you could move the GstAudioFormat format up to where the
endian variable is declared, and init it to 0 or FORMAT_UNKNOWN. Then in the
NONE/RAW case you'd set that to U8 if samples_per_byte == 1 and then you fall
through to the twos/sowt case. Then later you check if format is already set,
and if not use gst_audio_format_build_integer().

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.