[Bug 747774] dashdemux: text streams support

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=747774

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #307900|none                        |reviewed
             status|                            |

--- Comment #2 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 307900:
 --> (https://bugzilla.gnome.org/review?bug=747774&attachment=307900)

::: ext/dash/gstdashdemux.c
@@ +866,3 @@
+    caps = gst_caps_from_string ("application/x-mp4-text");
+  else
+    caps = gst_caps_from_string (mimeType);

How about moving this stream_contains_subtitles to mpdparser as the other
mimetype to caps conversions are being done there. The difference here is that
you need also to check the codec field. What do you think of adding a new
gst_mpd_client_get_stream_caps() that would handle the previous and this new
case?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.