[Bug 752912] Regression: vaapidecode ! glimagesink broken since GL overlay composition

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752912

Matthew Waters <ystreet00 at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308196|none                        |reviewed
             status|                            |

--- Comment #4 from Matthew Waters <ystreet00 at gmail.com> ---
Review of attachment 308196:
 --> (https://bugzilla.gnome.org/review?bug=752912&attachment=308196)

I made a very similar patch!

FWIW, it also breaks v4l2src ! glimagesink.

Feel free to push after fixing the issue below.

::: gst-libs/gst/gl/gstglupload.c
@@ +164,2 @@
   features = gst_caps_get_features (out_caps, 0);
+  if (!gst_caps_features_contains (features,
GST_CAPS_FEATURE_MEMORY_GL_MEMORY))

I had this for the entirety of feature checking in gl_memory_upload_accept.
i.e. performing the contains on both in_caps and out_caps.

  features = gst_caps_get_features (out_caps, 0);
  if (!gst_caps_features_contains (features,
GST_CAPS_FEATURE_MEMORY_GL_MEMORY))
    return FALSE;

  features = gst_caps_get_features (in_caps, 0);
  if (!gst_caps_features_contains (features, GST_CAPS_FEATURE_MEMORY_GL_MEMORY)
      && !gst_caps_features_contains (features,
          GST_CAPS_FEATURE_MEMORY_SYSTEM_MEMORY))
    return FALSE;

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.