[Bug 705991] Adding support for DASH common encryption to qtdemux and dashdemux

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=705991

--- Comment #144 from A Ashley <bugzilla at ashley-family.net> ---
(In reply to Tim-Philipp Müller from comment #141)
> Comment on attachment 308359 [details] [review]
> qtdemux: use GPtrArray for crypto_info to avoid GstStructure copies
> 
> Thanks. I was going to say you should merge this into the other patch. First
> some comments on this though, and I skipped it when reviewing the other
> patch since I thought you had a fix for it:
> 
> GstCaps should IMHO only be used for caps, not as some auxiliary helper
> object
> 
> I don't entirely understand what you're trying to achieve here. Ok, so
> structures are not refcounted and you're trying to avoid a structure copy.
> But what you're doing with _steal_structure() here means the GstCaps in the
> array are going to be useless and can't be used again (might they ever be
> used again, e.g. when seeking back?). So why jump through GstCaps hoops in
> the first place? You might just as well put the GstStructure into the array
> and then steal it and set the value in the array to NULL. That's basically
> the same thing you're doing now just without the extra caps objects, no?

I did try something like that but was not able to get it working. I think the
issue was that the GstStructure pointers were being freed by GPtrArray that had
already been passed downstream in a GstMeta. I will have another go, just using
a simple GstStructure** array.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.