[Bug 752850] matroskademux: Does not send user-supplied metadata tags from streamable files

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752850

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308425|none                        |reviewed
             status|                            |

--- Comment #8 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 308425:
 --> (https://bugzilla.gnome.org/review?bug=752850&attachment=308425)

About the commit message, ideally put your full name. The commit format we
prefer would be something like:

matroskademux: Preserve forward referenced track tags

Longer description here

bug_URI

::: gst/matroska/matroska-demux.c
@@ +1132,3 @@
+  /* check for a cached track taglist  */
+  cached_taglist =
+      (GstTagList *) g_hash_table_lookup (demux->common.cached_track_taglists,

I'm not sure, if this tag list is ever going to be reused ? If not, maybe call
gst_hash_table_remove() (after merging), so we don't keep it in memory.

::: gst/matroska/matroska-read-common.c
@@ +2877,3 @@
   g_object_unref (ctx->adapter);
+  g_hash_table_remove_all (ctx->cached_track_taglists);
+  g_hash_table_unref (ctx->cached_track_taglists);

Unref shall be sufficient.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.