[Bug 752690] h263parse: update proper PAR calculations

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752690

Tim-Philipp Müller <t.i.m at zen.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |t.i.m at zen.co.uk

--- Comment #4 from Tim-Philipp Müller <t.i.m at zen.co.uk> ---
FWIW, this only happens on negotiation and is not a recurrent message, so DEBUG
would have been perfectly fine as wlel.

(In reply to Vineeth from comment #0)
> In case of h263 video format, libav is calculating the PAR as 12/11
> but qtdemux is overwriting it to 1/1, resulting in wrong PAR being passed on.
> So instead of just using the PAR from demuxer, check the PAR value in parser,
> and compare the demuxer and parser PAR to determine the actual PAR.
> 
> This will align the PAR calculation to how it is done in libav, gstavviddec.c

I would like to understand what you're trying to achieve here exactly.

Am I correct to think that it works correctly with avdec_h263* (because it does
the same logic) ?

But you want to do this logic in h263parsers, so that other decoders get the
right par from the start?

Or what is the goal here? (Not saying there's anything wrong with the patch,
just wondering)

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.