[Bug 566605] Support the new libav metadata API

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=566605

Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308453|none                        |needs-work
             status|                            |

--- Comment #4 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 308453:
 --> (https://bugzilla.gnome.org/review?bug=566605&attachment=308453)

::: ext/libav/gstavutils.c
@@ +494,3 @@
+
+static gchar *
+my_safe_copy (gchar * input)

Hmm, using my_ is uncommon in gstreamer ;-P

@@ +524,3 @@
+    g_hash_table_insert (tmp, (void *) "comment", (void *) GST_TAG_COMMENT);
+    g_hash_table_insert (tmp, (void *) "composer", (void *) GST_TAG_COMPOSER);
+    g_hash_table_insert (tmp, (void *) "copyright", (void *)
GST_TAG_COPYRIGHT);

There is usually no reason in C to cast to void *.

@@ +526,3 @@
+    g_hash_table_insert (tmp, (void *) "copyright", (void *)
GST_TAG_COPYRIGHT);
+    //g_hash_table_insert (tmp, "creation_time", GST_TAG_DATE_TIME); /* Need
to convert ISO 8601 to GstDateTime */
+    //g_hash_table_insert (tmp, "date", GST_TAG_DATE); /* ditto */

C++ style comments. And why is there something commented out ?

::: ext/libav/gstavutils.h
@@ +96,3 @@

+GstTagList *
+gst_ffmpeg_metadata_to_tag_list (AVDictionary * metadata);

Should on same line, but I see you are following already in place style.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.