[Bug 752714] dashdemux: index information returned by gst_mpd_client_get_next_fragment is not used

[GStreamer (GNOME Bugzilla)]

https://bugzilla.gnome.org/show_bug.cgi?id=752714

Thiago Sousa Santos <thiagossantos at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
 Attachment #308394|none                        |reviewed
             status|                            |

--- Comment #3 from Thiago Sousa Santos <thiagossantos at gmail.com> ---
Review of attachment 308394:
 --> (https://bugzilla.gnome.org/review?bug=752714&attachment=308394)

::: ext/dash/gstmpdparser.c
@@ +2540,3 @@
 gst_mpdparser_build_URL_from_template (const gchar * url_template,
+    const gchar * id, guint number, guint bandwidth, guint64 time,
+    gboolean * used_number_or_time)

What do you think of making this an input parameter instead? The user would set
if it wants any index, global index or segment index. This way you enforce the
caller to select what kind of index it wants rather than returning anything and
expeting a post-call check.

The reason for enforcing is that with time people tend to forget these small
details of the code and this post-check might be forgotten when the code
evolves.

What do you think?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.