[Bug 748390] validate: media-descriptor: remove duplicate conditions

GStreamer (GNOME Bugzilla) bugzilla at gnome.org
Thu Jul 30 13:25:03 PDT 2015


https://bugzilla.gnome.org/show_bug.cgi?id=748390

--- Comment #18 from Nicolas Dufresne (stormer) <nicolas.dufresne at collabora.co.uk> ---
Review of attachment 308052:
 --> (https://bugzilla.gnome.org/review?bug=748390&attachment=308052)

I really wonder why we do media check if non of the test cause
failure/regression ?

::: validate/tools/gst-validate-media-check.c
@@ +122,3 @@
+    if (!gst_media_descriptors_compare (GST_MEDIA_DESCRIPTOR (reference),
+            GST_MEDIA_DESCRIPTOR (writer))) {
+      ret = 1;

This is the only thing that can cause a test to fail now. It looks like stream
ID are no longer the same as when the media info was first generated.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.


More information about the gstreamer-bugs mailing list